gh-148947: dataclasses: fix error on empty __class__ cell #148948
Merged
JelleZijlstra merged 2 commits intopython:mainfrom Apr 25, 2026
Merged
gh-148947: dataclasses: fix error on empty __class__ cell #148948JelleZijlstra merged 2 commits intopython:mainfrom
JelleZijlstra merged 2 commits intopython:mainfrom
Conversation
Also add a test demonstrating the need for the existing "is oldcls" check.
johnslavik
changed the title
johnslavik
approved these changes
Apr 24, 2026
johnslavik
changed the title
johnslavik
changed the title
Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
|
Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
GH-148995 is a backport of this pull request to the 3.14 branch. |
ljfp
pushed a commit
to ljfp/cpython
that referenced
this pull request
Apr 25, 2026
…on#148948) Also add a test demonstrating the need for the existing "is oldcls" check. Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
JelleZijlstra
added a commit
that referenced
this pull request
Apr 25, 2026
…148948) (#148995) gh-148947: dataclasses: fix error on empty __class__ cell (GH-148948) Also add a test demonstrating the need for the existing "is oldcls" check. (cherry picked from commit 6d7bbee) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also add a test demonstrating the need for the existing "is oldcls" check.
__class__cell #148947