gh-145591: Move slicing note to subscription methods section#145606
Open
Towaiji wants to merge 1 commit intopython:mainfrom
Open
gh-145591: Move slicing note to subscription methods section#145606Towaiji wants to merge 1 commit intopython:mainfrom
Towaiji wants to merge 1 commit intopython:mainfrom
Conversation
|
All commit authors signed the Contributor License Agreement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the slicing note out of the
object.__length_hint__section and places it with the subscription protocol underobject.__getitem__.That keeps the slicing translation example (
a[1:2] = b->a[slice(1, 2, None)] = b) next to the relevant special methods (__getitem__,__setitem__,__delitem__).Issue: #145591
📚 Documentation preview 📚: https://cpython-previews--145606.org.readthedocs.build/