Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion Lib/test/test_venv.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,13 @@
import os.path
import pathlib
import re
import shlex
import shutil
import subprocess
import sys
import sysconfig
import tempfile
import shlex
import time
from test.support import (captured_stdout, captured_stderr,
skip_if_broken_multiprocessing_synchronize, verbose,
requires_subprocess, is_android, is_apple_mobile,
Expand Down Expand Up @@ -373,6 +374,15 @@
with open(fn, 'wb') as f:
f.write(b'Still here?')

def test_install_scripts_selinux(self):
"""
gh-145417: Test that install_scripts does not copy SELinux context when
copying scripts.
"""

Check failure on line 381 in Lib/test/test_venv.py

View workflow job for this annotation

GitHub Actions / lint

Ruff (invalid-syntax)

Lib/test/test_venv.py:378:5: invalid-syntax: Expected an indented block after function definition
with patch('os.listxattr') as listxattr_mock:
venv.create(self.env_dir)
listxattr_mock.assert_not_called()

def test_overwrite_existing(self):
"""
Test creating environment in an existing directory.
Expand Down
2 changes: 1 addition & 1 deletion Lib/venv/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -581,7 +581,7 @@ def skip_file(f):
'may be binary: %s', srcfile, e)
continue
if new_data == data:
shutil.copy2(srcfile, dstfile)
shutil.copy(srcfile, dstfile)
else:
with open(dstfile, 'wb') as f:
f.write(new_data)
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Prevent incorrect preservation of SELinux context when copying scripts in :mod:`venv`.
Loading