Skip to content

gh-142349: Clarify lazy import filters have positional-only parameters - #144856

Merged
encukou merged 7 commits into
python:mainfrom
johnslavik:lazy-imports-filter-clarify-signature-positional
Jul 28, 2026
Merged

gh-142349: Clarify lazy import filters have positional-only parameters#144856
encukou merged 7 commits into
python:mainfrom
johnslavik:lazy-imports-filter-clarify-signature-positional

Conversation

@johnslavik

@johnslavik johnslavik commented Feb 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Failing example:

import sys

sys.set_lazy_imports_filter(lambda *, importing_module, imported_module, fromlist: True)

lazy import foobar

📚 Documentation preview 📚: https://cpython-previews--144856.org.readthedocs.build/

@bedevere-app bedevere-app Bot mentioned this pull request Feb 15, 2026
Open
5 tasks
@bedevere-app bedevere-app Bot added the docs Documentation in the Doc dir label Feb 15, 2026
@johnslavik johnslavik changed the title gh-131885: Clarify lazy import filters have positional-only arguments gh-131885: Clarify lazy import filters have positional-only parameters Feb 15, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Feb 15, 2026
@johnslavik
johnslavik requested a review from AA-Turner February 15, 2026 23:56
AA-Turner
AA-Turner previously requested changes Feb 15, 2026
View reviewed changes
Comment thread Doc/library/sys.rst Outdated
@bedevere-app

bedevere-app Bot commented Feb 15, 2026

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@johnslavik

johnslavik commented Feb 16, 2026

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again

@bedevere-app

bedevere-app Bot commented Feb 16, 2026

Copy link
Copy Markdown

Thanks for making the requested changes!

@AA-Turner: please review the changes made to this pull request.

@bedevere-app
bedevere-app Bot requested a review from AA-Turner February 16, 2026 00:07
@johnslavik

johnslavik commented Feb 21, 2026

Copy link
Copy Markdown
Member Author

@AA-Turner :-)

@johnslavik

johnslavik commented Mar 20, 2026

Copy link
Copy Markdown
Member Author

@AA-Turner

@johnslavik

johnslavik commented Apr 15, 2026

Copy link
Copy Markdown
Member Author

@AA-Turner (If you can't look into this I'll appreciate if you just tell! Thanks!)

@github-actions

github-actions Bot commented May 17, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label May 17, 2026
@johnslavik

johnslavik commented May 17, 2026

Copy link
Copy Markdown
Member Author

@AA-Turner

@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label May 26, 2026
@johnslavik

johnslavik commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

@AA-Turner :-)

@johnslavik
johnslavik requested a review from encukou July 24, 2026 18:59
@johnslavik

johnslavik commented Jul 24, 2026

Copy link
Copy Markdown
Member Author

I'm requesting a review from @encukou as Adam is unavailable.

@read-the-docs-community

read-the-docs-community Bot commented Jul 24, 2026 •
edited
Loading

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #33779896 | 📁 Comparing 9a2a9f4 against main (46acb79)

  🔍 Preview build  

7 files changed · ± 7 modified

± Modified

encukou
encukou reviewed Jul 24, 2026
View reviewed changes

@encukou encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asking for review is asking for nitpicks, right?

Please click "update branch" or do git merge main (depending on your workflow) to get the tools the current CI needs.

Comment thread Doc/library/sys.rst Outdated
Comment thread Doc/library/sys.rst Outdated
@johnslavik
johnslavik requested a review from encukou July 25, 2026 07:57
@johnslavik

johnslavik commented Jul 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Thank you so much for providing the suggestions!

@johnslavik johnslavik changed the title gh-131885: Clarify lazy import filters have positional-only parameters gh-142349: Clarify lazy import filters have positional-only parameters Jul 25, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jul 25, 2026
Open
@johnslavik

johnslavik commented Jul 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Changed the targeted issue to match.

encukou
encukou reviewed Jul 27, 2026
View reviewed changes
Comment thread Doc/library/sys.rst Outdated
@encukou encukou added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes and removed needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jul 27, 2026
@encukou
encukou dismissed AA-Turner’s stale review July 27, 2026 14:49

Requested changes were made.

@encukou
encukou merged commit 66eb823 into python:main Jul 28, 2026
58 of 65 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Jul 28, 2026
@miss-islington-app

miss-islington-app Bot commented Jul 28, 2026

Copy link
Copy Markdown

Thanks @johnslavik for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Jul 28, 2026

Copy link
Copy Markdown

GH-154808 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 28, 2026
encukou pushed a commit that referenced this pull request Jul 28, 2026
@miss-islington @johnslavik
[3.15] gh-142349: Clarify lazy import filters have positional-only pa…
3e670c3 
…rameters (GH-144856) (GH-154808)

(cherry picked from commit 66eb823)

Co-authored-by: Bartosz Sławecki <bartosz@ilikepython.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou left review comments
@AA-Turner AA-Turner Awaiting requested review from AA-Turner

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news topic-lazy-imports

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@johnslavik @encukou @AA-Turner @Yhg1s