gh-143405: Fix free-threaded build detection for Py_GIL_DISABLED #143406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`sysconfig.get_config_var("Py_GIL_DISABLED")` may be defined as 0 on
non-free-threaded builds. The previous check used `is not None`, which
incorrectly treated `Py_GIL_DISABLED=0` as a free-threaded build.
Signed-off-by: Yongtao Huang <yongtaoh2022@gmail.com>
hyongtao-code
force-pushed
the
fix-sample
branch
from
818a92a to
23c3bcf
Compare
hyongtao-code
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix inverted mapping between all_threads and only_active_thread in the non-free-threaded RemoteUnwinder code path.Add a regression test to ensure the correct behavior.sysconfig.get_config_var("Py_GIL_DISABLED")may be defined as 0 on non-free-threaded builds. The previous check usedis not None, which incorrectly treatedPy_GIL_DISABLED=0as a free-threaded build.