gh-143228: Fix UAF in perf trampoline during finalization #143233
Merged
+66
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
requested review from
ZeroIntensity and
ericsnowcurrently
as code owners
pablogsal
added
needs backport to 3.13
Member
Fidget-Spinner
left a comment
Fidget-Spinner
left a comment
There was a problem hiding this comment.
Looks good, just one question
When toggling perf trampoline while threads are running, or during interpreter finalization with daemon threads active, a use-after-free occurs. The munmap call in free_code_arenas releases executable memory while other threads may still be executing within trampolines or unwinding through them, causing SIGSEGV or SystemError. The fix uses reference counting with a code watcher. Each code object that receives a trampoline increments a refcount. When code objects are destroyed, the watcher decrements the refcount and frees arenas only when it reaches zero. This ensures trampolines are never freed while any code object could still reference them.
Fidget-Spinner
approved these changes
Dec 28, 2025
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
|
Sorry, @pablogsal, I could not cleanly backport this to |
|
Sorry, @pablogsal, I could not cleanly backport this to |
|
GH-143247 is a backport of this pull request to the 3.14 branch. |
pablogsal
added a commit
to pablogsal/cpython
that referenced
this pull request
Dec 28, 2025
pythonGH-143233) (cherry picked from commit 3ccc76f) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal
added a commit
to pablogsal/cpython
that referenced
this pull request
Dec 28, 2025
pythonGH-143233) (cherry picked from commit 3ccc76f) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
|
GH-143248 is a backport of this pull request to the 3.13 branch. |
pablogsal
added a commit
to pablogsal/cpython
that referenced
this pull request
Dec 28, 2025
pythonGH-143233) (cherry picked from commit 3ccc76f) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal
added a commit
that referenced
this pull request
Dec 28, 2025
pablogsal
added a commit
that referenced
this pull request
Dec 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When toggling perf trampoline while threads are running, or during
interpreter finalization with daemon threads active, a use-after-free
occurs. The munmap call in free_code_arenas releases executable memory
while other threads may still be executing within trampolines or
unwinding through them, causing SIGSEGV or SystemError.
The fix uses reference counting with a code watcher. Each code object
that receives a trampoline increments a refcount. When code objects are
destroyed, the watcher decrements the refcount and frees arenas only
when it reaches zero. This ensures trampolines are never freed while
any code object could still reference them.