gh-143200: fix UAFs in Element.__{set,get}item__ when the element is concurrently mutated
#143226
+85
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
added
topic-XML
needs backport to 3.13
| elem = b.close() | ||
| self.assertEqual(elem[0].tail, 'ABCDEFGHIJKL') | ||
|
|
||
| def test_subscr(self): |
Member
There was a problem hiding this comment.
Did you remove the old tests?
Member
Author
There was a problem hiding this comment.
No, I just refactored them
Member
Author
There was a problem hiding this comment.
Well.. strictly speaking I don't have the case "1 child" anymore. Is it important?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
element_[ass_]subscrvia re-entrant calls #143200