gh-143183: Rewind stop tracing to previous target #143187
Open
+49
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kumar Aditya <kumaraditya@python.org>
tomasr8
approved these changes
Dec 28, 2025
Member
tomasr8
left a comment
tomasr8
left a comment
There was a problem hiding this comment.
Just some nits, otherwise looks good!
| // gh-143183: It's important we rewind to the last known proper target. | ||
| // The current target might be garbage as stop tracing usually indicates | ||
| // we are in something that we can't trace. | ||
| goto unsupported; |
Member
There was a problem hiding this comment.
Is it worth to add a DPRINTF() here? All the other goto unsupported have it
| if (opcode == BINARY_OP_SUBSCR_GETITEM && old_stack_level + 1 > old_code->co_stacksize) { | ||
| unsupported: | ||
| { | ||
| // Rewind to previous instruction and replace with _EXIT_TRACE. |
Member
There was a problem hiding this comment.
Suggested change
| // Rewind to previous instruction and replace with exit_op. |
| except StopIteration: | ||
| break | ||
| for _ in range({TIER2_THRESHOLD // 40}): |
Member
There was a problem hiding this comment.
Just curious, does the number of iterations depend on TIER2_THRESHOLD? Why specifically 40?
Member
Author
There was a problem hiding this comment.
If it's too high, the test takes forever to run. So this just makes sure we have a number high enough that triggers without taking too long.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #143183
stopiteration_error#143183