-
-
Notifications
You must be signed in to change notification settings - Fork 33.3k
gh-87710: Update mime type for .ai
#141239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
gh-87710: Update mime type for .ai
#141239
Conversation
| '.so' : 'application/octet-stream', | ||
| '.oda' : 'application/oda', | ||
| '.ogx' : 'application/ogg', | ||
| '.ai' : 'application/pdf', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the .pdf should go first here, from the comment:
# Make sure the entry with the preferred file extension for a particular mime type
# appears before any others of the same mimetype.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we'd add a test that .pdf is returned as the preferred extension for application/pdf.
| '.so' : 'application/octet-stream', | ||
| '.oda' : 'application/oda', | ||
| '.ogx' : 'application/ogg', | ||
| '.ai' : 'application/pdf', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we'd add a test that .pdf is returned as the preferred extension for application/pdf.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Uh oh!
There was an error while loading. Please reload this page.