Skip to content

Conversation

@StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Nov 8, 2025

@StanFromIreland StanFromIreland requested a review from a team as a code owner November 8, 2025 13:05
@StanFromIreland StanFromIreland requested review from hugovk and removed request for a team November 8, 2025 13:08
cmaloney
cmaloney previously approved these changes Nov 9, 2025
'.so' : 'application/octet-stream',
'.oda' : 'application/oda',
'.ogx' : 'application/ogg',
'.ai' : 'application/pdf',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the .pdf should go first here, from the comment:

# Make sure the entry with the preferred file extension for a particular mime type
# appears before any others of the same mimetype.

Copy link
Member

@bitdancer bitdancer Nov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we'd add a test that .pdf is returned as the preferred extension for application/pdf.

'.so' : 'application/octet-stream',
'.oda' : 'application/oda',
'.ogx' : 'application/ogg',
'.ai' : 'application/pdf',
Copy link
Member

@bitdancer bitdancer Nov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we'd add a test that .pdf is returned as the preferred extension for application/pdf.

@bedevere-app
Copy link

bedevere-app bot commented Nov 9, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants