gh-48511: Make pwd and grp expose inner errors - #102223
Open
simaoafonso-pwt wants to merge 2 commits into
Open
Conversation
|
This PR is stale because it has been open for 30 days with no activity. |
simaoafonso-pwt
force-pushed
the
bpo-4261
branch
from
April 13, 2026 11:28
8f86d34 to
12f1a0a
Compare
Author
|
Rebased to the latest |
simaoafonso-pwt
marked this pull request as ready for review
June 5, 2026 15:24
Author
|
Rebased to the latest It seems the CI failure is unrelated. |
Test failed due error type change. Line 270 in 206788a Because pwd.getpwnam("foo") now raises FileNotFoundError (a subclass of OSError) instead of KeyError, the except KeyError: block in expanduser() fails to catch it, causing the FileNotFoundError to propagate up and fail test_expanduser_pwd. |
Distinguish between the case when the user/group does not exist and error conditions. If the user does not exit, raise KeyError as now, for errors raise OSError.
simaoafonso-pwt
force-pushed
the
bpo-4261
branch
from
July 27, 2026 10:37
b44db0d to
e81af12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Distinguish between the case when the user/group does not exist and error conditions.
If the user does not exit, raise KeyError as now, for errors raise OSError.
Based on arhadthedev@46c34b6