fix(dependencies): sort requirements files - #1330
Conversation
`_write_requirements_file()` wrote requirement sets in iteration order so rebuilds of identical sources could produced different files even though the content was the same. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Martin Prpič <mprpic@redhat.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This change deterministically orders generated requirement files without an identified current-head risk. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Tick the box to add this pull request to the merge queue (same as
|
_write_requirements_file()wrote requirement sets in iteration order so rebuilds of identical sources could produced different files even though the content was the same.Pull Request Description
What
Sort the fromager-build-system-requirements.txt file.
Why
Reproducibility.
Reproducer: