Open
Conversation
Fix performance issues in `analyze_zipmember` and `analyze_tarmember` functions. The elftools `ELFFile` class performance a lot of seek and small read operations. Seeking in a zipfile and tarfile is slow. The old implementation takes about 1.56s to analyze Pillow's 12.2.0 wheel for x86_64. The new code takes 0.22s. The performance difference is even more dramatic with Torch. With the new code, it takes less than 2 seconds to analyze a Torch 2.10.0+cpu wheel. The old code never finished in a reasonable amount of time. Signed-off-by: Christian Heimes <cheimes@redhat.com>
rd4398
approved these changes
Apr 20, 2026
rd4398
left a comment
rd4398
left a comment
There was a problem hiding this comment.
This looks good!
The 7x speedup on Pillow and making Torch analysis finish in <2s vs timing out is really impressive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix performance issues in
analyze_zipmemberandanalyze_tarmemberfunctions. The elftoolsELFFileclass performance a lot of seek and small read operations. Seeking in a zipfile and tarfile is slow.The old implementation takes about 1.56s to analyze Pillow's 12.2.0 wheel for x86_64. The new code takes 0.22s. The performance difference is even more dramatic with Torch. With the new code, it takes less than 2 seconds to analyze a Torch 2.10.0+cpu wheel. The old code never finished in a reasonable amount of time.