Feat: Add socks #141
Open
Feat: Add socks #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I deployed the aiohttpSocks branch to my real application on Square Cloud, and it is working perfectly! I saw in the aiohttp-socks documentation that they recommend special exception handling for ProxyConnectionError and ProxyTimeoutError (checking e.cause). Would it be worth adding this to the do_request method for more robust proxy error reporting? |
Member
Author
|
I think that should propagate correctly? We have the two excepts there because we raise different errors, but these you should be able to expect just like in the example |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't write the tests yet, I couldn't find them immediately in PTB and I really should do smth else now.