Reject array slice assignment before mutating values - #600
Merged
frostming merged 1 commit intoSep 11, 2026
Merged
Conversation
Generated with OpenAI Codex.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Array.__setitem__rejects slice assignment only after modifying the underlying list. For example, assigning[9, 10]toa[1:2]on[1, 2, 3]raisesValueError, but leaves the in-memory value as[1, 9, 10, 3]while serialization still produces[1, 2, 3].Check for unsupported slices before converting or assigning the replacement. The six regression cases cover replacement, insertion, deletion through assignment, and extended/reversed slices. They assert that values and the original commented TOML remain unchanged after the exception, and that subsequent supported edits still round-trip.
Validation on Windows with Python 3.12.10: all 1,058 tests pass, including the TOML conformance suite. All six new cases fail on the unmodified implementation. All configured pre-commit hooks pass on the tracked repository files. Full mypy reports the same 29 diagnostics on both this branch and the unmodified upstream commit (five in project code and 24 in the test submodule).
Related: #599 addresses slice deletion in
__delitem__; this change concerns rejected slice assignment in__setitem__.Agent Drafting Metadata