Handle missing virtualenv in shell command#60
Open
bubaizhanshen wants to merge 1 commit into
Open
Conversation
StantonMatt
reviewed
Jun 2, 2026
StantonMatt
left a comment
There was a problem hiding this comment.
I checked this locally because it covers the virtualenvs.create=false path from #30.
On the PR branch, a scratch project with local virtualenvs.create false now returns exit code 1 with the new user-facing message instead of reaching the assertion, and it no longer prints the misleading Spawning shell within ... line first.
Local checks I ran on Python 3.12.13:
.venv/bin/python -m pytest -q tests/test_shell_command.py::test_shell_without_virtualenv_shows_error.venv/bin/python -m pytest -q.venv/bin/python -m ruff check src/poetry_plugin_shell/command.py tests/test_shell_command.py.venv/bin/python -m mypy src/poetry_plugin_shell/command.py tests/test_shell_command.py
I do not see a blocking issue from this pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30.
This replaces the internal assertion when
poetry shellis run without a virtualenv with a user-facing error. It also avoids printing the misleadingSpawning shell within ...line before the environment type is validated.Checks:
pytest tests/test_shell_command.py -q -n 0ruff check src/poetry_plugin_shell/command.py tests/test_shell_command.pyruff format --check src/poetry_plugin_shell/command.py tests/test_shell_command.pypre-commit run --all-files