Skip to content

Use a critical section to protect getlist() #9853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lazerg wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −1
Open

Use a critical section to protect getlist() #9853

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/_imaging.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@

#define PY_SSIZE_T_CLEAN
#include "Python.h"
#include "thirdparty/pythoncapi_compat.h"

#ifdef HAVE_LIBJPEG
#include "jconfig.h"
Expand Down Expand Up @@ -418,7 +419,7 @@ getbands(const ModeID mode) {
#define TYPE_DOUBLE (0x400 | sizeof(double))

static void *
getlist(PyObject *arg, Py_ssize_t *length, const char *wrong_length, int type) {
getlist_impl(PyObject *arg, Py_ssize_t *length, const char *wrong_length, int type) {
/* - allocates and returns a c array of the items in the
python sequence arg.
- the size of the returned array is in length
Expand Down Expand Up @@ -499,6 +500,15 @@ getlist(PyObject *arg, Py_ssize_t *length, const char *wrong_length, int type) {
return list;
}

static void *
getlist(PyObject *arg, Py_ssize_t *length, const char *wrong_length, int type) {
void *result;
Py_BEGIN_CRITICAL_SECTION(arg);
result = getlist_impl(arg, length, wrong_length, type);
Py_END_CRITICAL_SECTION();
return result;
}

FLOAT32
float16tofloat32(const FLOAT16 in) {
UINT32 t1;
Expand Down
Loading