Use os.startfile() in WindowsViewer show_file()#9692
Open
radarhere wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WindowsViewercurrently usesstartfromget_command().Pillow/src/PIL/ImageShow.py
Lines 133 to 135 in 87e7883
However, a simpler method is to use
os.startfile. This prevents injection. The temporary file can be removed after 20 seconds usingos.remove(), like 8da8013As for
get_command(), direct injection can be prevented by raising an error if double quotes are used infile. This is valid, because Windows filenames cannot contain them..Also in
get_command(), variable expansion can be prevented by quoting percentages.