Conversation
danking
marked this pull request as ready for review
September 22, 2026 14:35
akx
approved these changes
Sep 22, 2026
akx
left a comment
Contributor
There was a problem hiding this comment.
LGTM (from the sidelines, as it were). (I should maybe take a look at other places where we could release the GIL more than we do now...)
#9744 already sped RankFilter up a little (unreleased as of yet).
My little eye also spies an opportunity to hoist those ysize and xsize (see #9788 etc.) for an additional speed boost, but that sounds out of scope for this PR.
Author
|
Hmm... That feels a bit like I might have uncovered some concurrency issue. Can't look carefully now but I can take a look in ~8 hours. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn’t completely fix but is related to:
#6410
I noticed that MedianFilter doesn’t release the GIL which, for those of us not yet on free threaded Python, prevents us from fully utilizing all the cores.
I did use an LLM to do some research on pillow and to author these three lines but I would have written the exact same three. I simply don’t have a full sized keyboard at hand right now.
Thank you kindly for your time reviewing.