Fixing regression test for #517 so it fails on macos too#522
Merged
jamadden merged 1 commit intoJul 23, 2026
Merged
Conversation
The test only asked whether the class survived the collection, which a build without the fix can also satisfy: if the attribute lookup happened to take a strong _PyCStackRef instead of a deferred one, or any other reference lingered, the class stays alive and the test passes. That is why it kept passing on mac/3.15b3 while failing on manylinux/3.15b4. Look for the suspended greenlet in gc.get_referrers() of the class instead. That is the reference the fix creates, so a build without it reports the masking reference and fails wherever the class survives for some unrelated reason.
ddorian
changed the title
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for #517 regression test not replicating in macos. A demo where the test fails in all scenarios can be seen here: ddorian#1