Repository navigation
Conversation
All call-sites supply checkvars, and default was mutable.
In all cases suppression is as focused as possible.
slivingston
approved these changes
Oct 6, 2026
slivingston
left a comment
slivingston
left a comment
Member
There was a problem hiding this comment.
I noticed a small misprint. Else, this is good to merge.
Some of these ruff warnings involve changes that are safe, in particular unused unpacked variables (RUF059). Nonetheless, I agree with waiting for more test coverage before applying the suggested changes.
| ---------------------------- | ||
|
|
||
| When doing development one builds over and over; in that case it's faster to do a non-isolated editable build. Run or adapt developer script `inplace-editable-build.bash`_ for that. | ||
| When doing development one builds over and over; in that case it's faster to do a non-isolated editable build. Run or adapt developer script `inplace-editable-build.bash`_ for that. CMake variables can be set to configure the build; for example, in the command below, ``BLA_VENDOR`` is set to to tell CMake to use the Netlib BLAS/LAPACK libraries. This example is not merely illustrative: on Debian 13 *not* specifying ``BLA_VENDOR`` can cause test failures. |
Member
There was a problem hiding this comment.
Suggested change
| When doing development one builds over and over; in that case it's faster to do a non-isolated editable build. Run or adapt developer script `inplace-editable-build.bash`_ for that. CMake variables can be set to configure the build; for example, in the command below, ``BLA_VENDOR`` is set to to tell CMake to use the Netlib BLAS/LAPACK libraries. This example is not merely illustrative: on Debian 13 *not* specifying ``BLA_VENDOR`` can cause test failures. | |
| When doing development one builds over and over; in that case it's faster to do a non-isolated editable build. Run or adapt developer script `inplace-editable-build.bash`_ for that. CMake variables can be set to configure the build; for example, in the command below, ``BLA_VENDOR`` is set to tell CMake to use the Netlib BLAS/LAPACK libraries. This example is not merely illustrative: on Debian 13 *not* specifying ``BLA_VENDOR`` can cause test failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See discussion at gh-253.
Changes
__all__bugruff checkwarnings