Skip to content

test: size job-control output from page size - #1828

Open
traylenator wants to merge 1 commit into
python-cmd2:mainfrom
traylenator:page_size
Open

traylenator wants to merge 1 commit into
python-cmd2:mainfrom
traylenator:page_size

Conversation

@traylenator

Copy link
Copy Markdown
Contributor

On ppc64le,
test_pipeline_stops_with_cmd2_and_returns_terminal[interrupt-busy-producer] times out waiting for cmd2 to hand the terminal to the pager:

foreground process group: 605
  605 ... Sl+  hrtime  application.py
  633 ... S    poll_s  pager.py

The busy producers write 256 KiB, meant to be more than a pipe holds so that the write blocks and cmd2 lends the terminal. Linux sizes a pipe in pages, 16 by default, and ppc64le uses 64 KiB pages, so a pipe holds 1 MiB there. The write completes without blocking and the terminal is never lent.

Write 64 pages instead: unchanged at 256 KiB with 4 KiB pages, 4 MiB with 64 KiB pages.

On ppc64le,
test_pipeline_stops_with_cmd2_and_returns_terminal[interrupt-busy-producer]
times out waiting for cmd2 to hand the terminal to the pager:

    foreground process group: 605
      605 ... Sl+  hrtime  application.py
      633 ... S    poll_s  pager.py

The busy producers write 256 KiB, meant to be more than a pipe holds
so that the write blocks and cmd2 lends the terminal. Linux sizes a
pipe in pages, 16 by default, and ppc64le uses 64 KiB pages, so a pipe
holds 1 MiB there. The write completes without blocking and the
terminal is never lent.

Write 64 pages instead: unchanged at 256 KiB with 4 KiB pages, 4 MiB
with 64 KiB pages.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.75%. Comparing base (e5811a3) to head (c04b649).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1828   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files          23       23           
  Lines        6664     6664           
=======================================
  Hits         6648     6648           
  Misses         16       16           
Flag Coverage Δ
unittests 99.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant