Repository navigation
test: allow scaling job-control test timeouts - #1827
Closed
traylenator wants to merge 1 commit into
Closed
traylenator wants to merge 1 commit into
traylenator wants to merge 1 commit into
Conversation
On a slow ppc64le builder, test_pipeline_stops_with_ cmd2_and_returns_terminal[interrupt-busy-producer] gives up waiting for the shell to hand the terminal to the pipeline after 10 seconds. Add CMD2_TEST_TIMEOUT_SCALE, a multiplier for the limits on how long the job-control tests wait before failing. The busy producers' sleeps are scaled with them, so a busy producer is still running when the tests act on it. The short pauses that check that nothing happens are not scaled. Without the variable, every limit is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1827 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 23 23
Lines 6664 6664
=======================================
Hits 6648 6648
Misses 16 16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a slow ppc64le builder, test_pipeline_stops_with_ cmd2_and_returns_terminal[interrupt-busy-producer] gives up waiting for the shell to hand the terminal to the pipeline after 10 seconds.
Add CMD2_TEST_TIMEOUT_SCALE, a multiplier for the limits on how long the job-control tests wait before failing. The busy producers' sleeps are scaled with them, so a busy producer is still running when the tests act on it. The short pauses that check that nothing happens are not scaled. Without the variable, every limit is unchanged.