Skip to content

test: allow scaling job-control test timeouts - #1827

Closed
traylenator wants to merge 1 commit into
python-cmd2:mainfrom
traylenator:testtimeout
Closed

traylenator wants to merge 1 commit into
python-cmd2:mainfrom
traylenator:testtimeout

Conversation

@traylenator

Copy link
Copy Markdown
Contributor

On a slow ppc64le builder, test_pipeline_stops_with_ cmd2_and_returns_terminal[interrupt-busy-producer] gives up waiting for the shell to hand the terminal to the pipeline after 10 seconds.

Add CMD2_TEST_TIMEOUT_SCALE, a multiplier for the limits on how long the job-control tests wait before failing. The busy producers' sleeps are scaled with them, so a busy producer is still running when the tests act on it. The short pauses that check that nothing happens are not scaled. Without the variable, every limit is unchanged.

On a slow ppc64le builder, test_pipeline_stops_with_
cmd2_and_returns_terminal[interrupt-busy-producer]
gives up waiting for the shell to hand the terminal to the pipeline
after 10 seconds.

Add CMD2_TEST_TIMEOUT_SCALE, a multiplier for the limits on how long
the job-control tests wait before failing. The busy producers' sleeps
are scaled with them, so a busy producer is still running when the
tests act on it. The short pauses that check that nothing happens are
not scaled. Without the variable, every limit is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.75%. Comparing base (e5811a3) to head (9b95aac).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1827   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files          23       23           
  Lines        6664     6664           
=======================================
  Hits         6648     6648           
  Misses         16       16           
Flag Coverage Δ
unittests 99.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@traylenator
traylenator marked this pull request as draft November 17, 2026 09:59
@traylenator
traylenator deleted the testtimeout branch November 17, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant