Skip to content

test: scale pipe relay slack with page size - #1826

Open
traylenator wants to merge 1 commit into
python-cmd2:mainfrom
traylenator:slack
Open

traylenator wants to merge 1 commit into
python-cmd2:mainfrom
traylenator:slack

Conversation

@traylenator

Copy link
Copy Markdown
Contributor

On ppc64le, test_pipeline_writer_relay_lends_only_while_a_producer_waits[True] fails with:

AssertionError: assert 1114112 == 1163264

The test leaves a fixed 16 KiB slack, which assumes 4 KiB pages. A pipe frees space one whole page at a time, and ppc64le uses 64 KiB pages, so reading 16 KiB frees no space and the consumer comes up short. Use 4 pages of slack, so 4 KiB-page systems are unchanged.

On ppc64le, test_pipeline_writer_relay_lends_only_while_a_producer_waits[True]
fails with:

    AssertionError: assert 1114112 == 1163264

The test leaves a fixed 16 KiB slack, which assumes 4 KiB pages. A
pipe frees space one whole page at a time, and ppc64le uses 64 KiB
pages, so reading 16 KiB frees no space and the consumer comes up
short. Use 4 pages of slack, so 4 KiB-page systems are unchanged.
@codecov

codecov Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.75%. Comparing base (e5811a3) to head (ecf51e6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1826   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files          23       23           
  Lines        6664     6664           
=======================================
  Hits         6648     6648           
  Misses         16       16           
Flag Coverage Δ
unittests 99.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant