Repository navigation
test: scale pipe relay slack with page size - #1826
Open
traylenator wants to merge 1 commit into
Open
traylenator wants to merge 1 commit into
traylenator wants to merge 1 commit into
Conversation
On ppc64le, test_pipeline_writer_relay_lends_only_while_a_producer_waits[True]
fails with:
AssertionError: assert 1114112 == 1163264
The test leaves a fixed 16 KiB slack, which assumes 4 KiB pages. A
pipe frees space one whole page at a time, and ppc64le uses 64 KiB
pages, so reading 16 KiB frees no space and the consumer comes up
short. Use 4 pages of slack, so 4 KiB-page systems are unchanged.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1826 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 23 23
Lines 6664 6664
=======================================
Hits 6648 6648
Misses 16 16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On ppc64le, test_pipeline_writer_relay_lends_only_while_a_producer_waits[True] fails with:
The test leaves a fixed 16 KiB slack, which assumes 4 KiB pages. A pipe frees space one whole page at a time, and ppc64le uses 64 KiB pages, so reading 16 KiB frees no space and the consumer comes up short. Use 4 pages of slack, so 4 KiB-page systems are unchanged.