Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1825 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 23 23
Lines 6664 6665 +1
=======================================
+ Hits 6648 6649 +1
Misses 16 16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Linux with 256 KiB or 1 MiB pipes, two relay tests can pass without reaching the
terminal-lending check. Size all three tests from the destination pipe capacity, scale the
slow consumer's reads, and share the existing relay read size with the producer-wait test.
On x86_64 Linux (WSL2, CPython 3.12.13, 4 KiB pages),
make check,make test(3,078 passed, 5 skipped), and
make docs-testpassed. Real Linux pipes were set to 64 KiB,256 KiB, and 1 MiB. All four relay test cases reached the lending check and passed at each
capacity. Removing each lending guard separately made its target test fail at the expected
assertion at all three capacities. Native macOS and large-page kernels remain to be tested.
Prepared with OpenAI Codex assistance.
closes #1803