Skip to content

Size relay tests from pipe capacity - #1825

Open
sogav21 wants to merge 1 commit into
python-cmd2:mainfrom
sogav21:fix/relay-test-pipe-capacity
Open

sogav21 wants to merge 1 commit into
python-cmd2:mainfrom
sogav21:fix/relay-test-pipe-capacity

Conversation

@sogav21

@sogav21 sogav21 commented Nov 17, 2026

Copy link
Copy Markdown

On Linux with 256 KiB or 1 MiB pipes, two relay tests can pass without reaching the
terminal-lending check. Size all three tests from the destination pipe capacity, scale the
slow consumer's reads, and share the existing relay read size with the producer-wait test.

On x86_64 Linux (WSL2, CPython 3.12.13, 4 KiB pages), make check, make test
(3,078 passed, 5 skipped), and make docs-test passed. Real Linux pipes were set to 64 KiB,
256 KiB, and 1 MiB. All four relay test cases reached the lending check and passed at each
capacity. Removing each lending guard separately made its target test fail at the expected
assertion at all three capacities. Native macOS and large-page kernels remain to be tested.

Prepared with OpenAI Codex assistance.

closes #1803

@codecov

codecov Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.75%. Comparing base (e5811a3) to head (f1ccc97).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1825   +/-   ##
=======================================
  Coverage   99.75%   99.75%           
=======================================
  Files          23       23           
  Lines        6664     6665    +1     
=======================================
+ Hits         6648     6649    +1     
  Misses         16       16           
Flag Coverage Δ
unittests 99.75% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Size the remaining relay tests from the pipe capacity and share the relay chunk size

1 participant