Use PyGILState_Ensure to avoid accessing CPython internals - #269
Open
ngoldbaum wants to merge 2 commits into
Open
Use PyGILState_Ensure to avoid accessing CPython internals#269ngoldbaum wants to merge 2 commits into
ngoldbaum wants to merge 2 commits into
Conversation
nitzmahone
reviewed
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following a suggestion from @kumaraditya303, this removes direct access to the
PyThreadStatestruct ingil_ensure()and replaces it withPyGILState_Ensure.The direct struct access is the cause of the crash in #263.
The current code dates back to Python 3.6 and works around differences spanning the Python 2->3 transition. That is all historical now. The code that is currently active is identical to the content of
PyGILState_Ensure.