Skip to content

Don't count untranslated plurals in compile --statistics - #1473

Open
NotAFlightRisk wants to merge 1 commit into
python-babel:masterfrom
NotAFlightRisk:fix-statistics-untranslated-plural
Open

NotAFlightRisk wants to merge 1 commit into
python-babel:masterfrom
NotAFlightRisk:fix-statistics-untranslated-plural

Conversation

@NotAFlightRisk

Copy link
Copy Markdown

Make a Polish catalog with pybabel init -l pl, translate nothing, and pybabel compile --statistics says 1 of 2 messages (50%) translated on 2.18.0. The template had one plain message and one plural, and it's the plural being counted - its msgstr comes back as a tuple of empty strings, which is truthy.

With this it says 0 of 2. Plurals with only some forms filled in still count as translated, same as before.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant