Skip to content

Migrate dt4acc integration to pyaml-test-lattice and pin CS backends - #395

Merged
gupichon merged 3 commits into
mainfrom
394-feature-source-dt4acc-integration-latticeconfig-from-pyaml-test-lattice-pin-companion-deps
Sep 10, 2026
Merged

Migrate dt4acc integration to pyaml-test-lattice and pin CS backends#395
gupichon merged 3 commits into
mainfrom
394-feature-source-dt4acc-integration-latticeconfig-from-pyaml-test-lattice-pin-companion-deps

Conversation

@gupichon

Copy link
Copy Markdown
Member

Summary

  • Source the FODO_1GeV_6D lattice/config for the dt4acc integration pipeline from pyaml-test-lattice instead of a vendored copy under tests/integration/data/fodo_1gev_6d/, resolving --accelerator-setup-file/--lattice-file and the test fixtures through pyaml_test_lattice.configurations/lattices.
  • Pin tango-pyaml@0.3.3 and pyaml-cs-oa@0.2.0 in dt4acc-integration.yml instead of tracking main unpinned — both tags predate the MultiAttribute regression that broke CI on PR Fix typing for _fill_device() methods #393.
  • Deactivate test_chromaticity_measurement (same convention as the existing deactivated_test_orbit_correction): pyaml-test-lattice's current fixture has no BPMs/correctors or tuning tools yet.

Closes #394

Test plan

  • Local end-to-end run against a natively-launched dt4acc-soleil-twin (no WSL/Apptainer): both tango-pyaml and pyaml-cs-oa smoke tests pass.
  • Full non-integration suite (pytest tests -m "not integration") unaffected.
  • CI dt4acc-integration.yml run on this PR (Apptainer path).

@gupichon

Copy link
Copy Markdown
Member Author

Maybe we should tag tango-pyaml and release it? @TeresiaOlsson ?

@JeanLucPons

Copy link
Copy Markdown
Member

And pyaml-cs-oa too ?
There was also a recent fix.

@gupichon
gupichon merged commit 47be3c0 into main Sep 10, 2026
4 checks passed
@TeresiaOlsson

Copy link
Copy Markdown
Member

Maybe we should tag tango-pyaml and release it? @TeresiaOlsson ?

Yes, I would like that also so I can see that the documentation builds correctly for what readthedocs calls stable. Currently it only build latest.

@TeresiaOlsson

Copy link
Copy Markdown
Member

And pyaml-cs-oa too ? There was also a recent fix.

And maybe also pyaml? We can make pre-release tags if we are afraid of breaking things for users. But I think it would be good to make a release of all the packages this week so we have some days to fix potential bugs before the hackathon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: source dt4acc integration lattice/config from pyaml-test-lattice, pin companion deps

4 participants