Conversation
…4acc-integration-latticeconfig-from-pyaml-test-lattice-pin-companion-deps
Closed
2 tasks
Member
Author
|
Maybe we should tag tango-pyaml and release it? @TeresiaOlsson ? |
Member
|
And pyaml-cs-oa too ? |
JeanLucPons
approved these changes
Sep 10, 2026
Member
Yes, I would like that also so I can see that the documentation builds correctly for what readthedocs calls stable. Currently it only build latest. |
Member
And maybe also pyaml? We can make pre-release tags if we are afraid of breaking things for users. But I think it would be good to make a release of all the packages this week so we have some days to fix potential bugs before the hackathon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pyaml-test-latticeinstead of a vendored copy undertests/integration/data/fodo_1gev_6d/, resolving--accelerator-setup-file/--lattice-fileand the test fixtures throughpyaml_test_lattice.configurations/lattices.tango-pyaml@0.3.3andpyaml-cs-oa@0.2.0indt4acc-integration.ymlinstead of trackingmainunpinned — both tags predate theMultiAttributeregression that broke CI on PR Fix typing for _fill_device() methods #393.test_chromaticity_measurement(same convention as the existingdeactivated_test_orbit_correction):pyaml-test-lattice's current fixture has no BPMs/correctors or tuning tools yet.Closes #394
Test plan
dt4acc-soleil-twin(no WSL/Apptainer): bothtango-pyamlandpyaml-cs-oasmoke tests pass.pytest tests -m "not integration") unaffected.dt4acc-integration.ymlrun on this PR (Apptainer path).