Skip to content

Change type to class in configuration files - #391

Merged
TeresiaOlsson merged 7 commits into
mainfrom
change-type-to-class-in-config
Sep 11, 2026
Merged

Change type to class in configuration files#391
TeresiaOlsson merged 7 commits into
mainfrom
change-type-to-class-in-config

Conversation

@TeresiaOlsson

Copy link
Copy Markdown
Member

I have made the updates so the default key in the configuration is class_path/class instead of type. Type is still supported so configuration files which are using the old format still is possible to load.

I could only change the BESSY II example for now since the others need PR python-accelerator-middle-layer/tango-pyaml#35 to be merged before they can be validated.

I also didn't change the configurations in the tests for now to avoid breaking it before the hackathon. For now I mostly want to update the files that users might look at to learn how to write the configuration so they learn the new format.

@gupichon

Copy link
Copy Markdown
Member

Could you merge main into your branch to make sure everything is consistent with the recent changes?

@TeresiaOlsson
TeresiaOlsson force-pushed the change-type-to-class-in-config branch from 886fa63 to 0a976a2 Compare September 10, 2026 09:39
@TeresiaOlsson

Copy link
Copy Markdown
Member Author

Could you merge main into your branch to make sure everything is consistent with the recent changes?

I rebased it on the current main now.

@JeanLucPons

Copy link
Copy Markdown
Member

Could you merge main into your branch to make sure everything is consistent with the recent changes?

I rebased it on the current main now.
Thanks

@gupichon
rebase + force push is the good way to do in a PR otherwise it blends history in the main and in your branch and some old code can reappear in conflict resolutions. I already experienced such issue. So please , in a PR, use rebase.

@JeanLucPons
JeanLucPons self-requested a review September 11, 2026 06:46
@TeresiaOlsson
TeresiaOlsson merged commit dcf2c8e into main Sep 11, 2026
4 checks passed
@TeresiaOlsson
TeresiaOlsson deleted the change-type-to-class-in-config branch September 11, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants