Skip to content

Support Python 3.10-3.14, fix registry read_text() usage, drop unused accelerator-toolbox dependency - #6

Merged
gupichon merged 1 commit into
mainfrom
5-python-314-compatibility
Sep 11, 2026
Merged

Support Python 3.10-3.14, fix registry read_text() usage, drop unused accelerator-toolbox dependency#6
gupichon merged 1 commit into
mainfrom
5-python-314-compatibility

Conversation

@gupichon

@gupichon gupichon commented Sep 11, 2026

Copy link
Copy Markdown
Member

Summary

  • Fix ImportError: cannot import name 'Traversable' from 'importlib.abc' on Python 3.14 (reported by pyaml's CI): importlib.abc.Traversable was deprecated in 3.12 and removed in 3.14, so it's now imported from importlib.resources.abc with a fallback to importlib.abc for 3.10/3.11.
  • Fix Registry.__getitem__, which returned str(path) instead of the Traversable/Path object, silently breaking the README's documented lattice_file.read_text() usage. It now returns the entry itself.
  • Breaking change: drop the accelerator-toolbox runtime dependency, nothing in this package imports it, it's purely a file registry. Any project relying on it being pulled in transitively (e.g. pyaml) must now declare it as a direct dependency of its own.
  • Bump supported range to Python 3.10-3.14 (requires-python, classifiers, ruff/mypy target versions).
  • Add a pytest suite under tests/ exercising the README's documented usage (lattice/configuration access, .read_text(), descriptions) and the supported Python version range, plus a GitHub Actions workflow (unit-tests.yml) running it across Python 3.10, 3.11, 3.12, 3.13, and 3.14.

Closes #5

Test plan

  • pytest passes on Python 3.10 and Python 3.14 (conda envs)
  • ruff check . and ruff format --check . pass
  • CI matrix (unit-tests.yml) green on the PR

… accelerator-toolbox dependency

Add pytest suite and GitHub Actions workflow covering Python 3.10-3.14.
@gupichon gupichon linked an issue Sep 11, 2026 that may be closed by this pull request
@gupichon gupichon self-assigned this Sep 11, 2026
@gupichon
gupichon requested a review from GamelinAl September 11, 2026 09:47
@gupichon
gupichon merged commit 9e2229d into main Sep 11, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python 3.14 compatibility

3 participants