Skip to content

Fix Tango Read Only attribute - #45

Merged
JeanLucPons merged 2 commits into
mainfrom
fix-for-rw-tango-att
Sep 9, 2026
Merged

Fix Tango Read Only attribute#45
JeanLucPons merged 2 commits into
mainfrom
fix-for-rw-tango-att

Conversation

@JeanLucPons

Copy link
Copy Markdown
Member

This PR fix wrong behavior for Tango read only attribute.
(This is a temporary fix that need better Ophyd investigation to be improved).

@JeanLucPons JeanLucPons changed the title Fix signal name method Fix Tango Read Only attribute Sep 8, 2026

@TeresiaOlsson TeresiaOlsson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The only thing I thought about is if:

        elif isinstance(self._cfg, (EpicsConfigW, EpicsConfigRW)):
            return self._cfg.write_pvname

should return a string with both the write and read PV. Or that won't work because of the expected return format?

@JeanLucPons

Copy link
Copy Markdown
Member Author

name() is supposed to return the read pv name when read only and the write pv name otherwise while measure_name() should return the read pv name except for write only.

@JeanLucPons
JeanLucPons merged commit 25ef181 into main Sep 9, 2026
3 checks passed
@JeanLucPons
JeanLucPons deleted the fix-for-rw-tango-att branch September 9, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants