Fix Tango Read Only attribute - #45
Merged
Merged
Conversation
TeresiaOlsson
left a comment
Member
There was a problem hiding this comment.
Looks good. The only thing I thought about is if:
elif isinstance(self._cfg, (EpicsConfigW, EpicsConfigRW)):
return self._cfg.write_pvname
should return a string with both the write and read PV. Or that won't work because of the expected return format?
Member
Author
|
|
TeresiaOlsson
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix wrong behavior for Tango read only attribute.
(This is a temporary fix that need better Ophyd investigation to be improved).