Repository navigation
Fix approx() raising InvalidOperation on Decimal("NaN") actual value - #15336
Closed
duongynhi000005-oss wants to merge 1 commit into
Closed
duongynhi000005-oss wants to merge 1 commit into
duongynhi000005-oss wants to merge 1 commit into
Conversation
When the actual value is Decimal('NaN') and expected is finite,
ApproxScalar.__eq__ previously evaluated
`abs(self.expected - actual) <= self.tolerance`, which raises
decimal.InvalidOperation under the default Decimal context.
Return False early when `_is_nan(abs(actual))` and expected is finite,
matching float('nan') behavior.
Fixes pytest-dev#15335.
Signed-off-by: duongynhi000005-oss <duongynhi000005@gmail.com>
pyba-chronographer
Bot
added
the
bot:chronographer:provided
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15335.
When the actual value is
Decimal("NaN")and the expected value is finite,ApproxScalar.__eq__previously evaluatedabs(self.expected - actual) <= self.tolerance, raisingdecimal.InvalidOperationunder the defaultdecimalcontext instead of comparing unequal.Return
Falseearly when_is_nan(abs(actual))(after handling a NaN expected value), matchingfloat("nan")behavior.Checklist