Repository navigation
Conversation
pyba-chronographer
Bot
added
the
bot:chronographer:provided
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #15329.
When a fixture raises a
BaseExceptionGroup(such as one containingasyncio.CancelledErrororGeneratorExit) during teardown,SetupState.teardown_exact()previously failed to catch it because the loop only caughtTEST_OUTCOME = (OutcomeException, Exception). As a result, execution aborted before remaining item finalizers could run, leaving dependent fixtures uncleared in the fixture cache and leaking into subsequent tests.This PR updates the teardown catch in
SetupState.teardown_exact()to(*TEST_OUTCOME, BaseExceptionGroup), allowing finalizer draining to complete while aggregating all teardown exceptions.Repro & Verification
Local reproducer from BaseExceptionGroup during fixture teardown skips remaining finalizers and reuses a cached function-scoped fixture #15329 (
test_lifecycle.pywith anownerfixture andresourcefixture raisingBaseExceptionGroup("cleanup", [asyncio.CancelledError("cancel marker"), RuntimeError("ordinary marker")])):test_firsterror,test_nextfailed (AssertionError: cached function-scoped owner reused, token 1 reused instead of new allocation).test_firsterror,test_nextpassed (token == 2).Tests run:
pytest testing/test_runner.py: 71 passed, 1 xfailed.