Skip to content

Fix crash on empty xfail parameter set with --runxfail - #15056

Open
SemTiOne wants to merge 1 commit into
pytest-dev:mainfrom
SemTiOne:fix/4497-runxfail-empty-params
Open

SemTiOne wants to merge 1 commit into
pytest-dev:mainfrom
SemTiOne:fix/4497-runxfail-empty-params

Conversation

@SemTiOne

Copy link
Copy Markdown
Contributor

Supersedes #7289. That attempt guarded with hasattr and returned None; this raises a clean failure when no direct parameter exists.

Out of scope by design: whether --runxfail should override the empty-set xfail(run=False) at all. This PR only turns the crash into a clear failure.

Closes #4497.

  • Allow maintainers to push and squash when merging my commits. Please uncheck this if you prefer to squash the commits yourself.

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
@psf-chronographer psf-chronographer Bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Sep 17, 2026
@SemTiOne SemTiOne closed this Sep 17, 2026
@SemTiOne SemTiOne reopened this Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided (automation) changelog entry is part of PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

empty_parameter_set_mark = xfail + --runxfail => crash

1 participant