Fix duplicate values in Config.known_args_namespace for append actions#14422
Open
EternalRights wants to merge 3 commits intopytest-dev:mainfrom
Open
Fix duplicate values in Config.known_args_namespace for append actions#14422EternalRights wants to merge 3 commits intopytest-dev:mainfrom
EternalRights wants to merge 3 commits intopytest-dev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into #13484 while looking at the config parsing code. The third
parse_known_argscall passesself.known_args_namespaceas the namespace, which already has values from the second parse. Foraction="append"options like-W, this causes duplicates.Fix is to use
copy.copy(self.option)instead, same as the first two calls. This way each parse starts from a clean namespace andappendactions don't accumulate across multiple parses.Not sure if there was a reason the third call used
known_args_namespacedirectly, but from what I can tell the only new things after the second parse are plugin-registered options, and those would still be picked up correctly with a fresh namespace.Closes #13484