-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
fixtures: --fixtures/--fixtures-per-test don't go through pytest_collection #15049
Copy link
Copy link
Open
Labels
topic: collectionrelated to the collection phaserelated to the collection phasetopic: fixturesanything involving fixtures directly or indirectlyanything involving fixtures directly or indirectlytype: backward compatibilitymight present some backward compatibility issues which should be carefully noted in the changelogmight present some backward compatibility issues which should be carefully noted in the changelog
Description
Activity
Metadata
Metadata
Assignees
Labels
topic: collectionrelated to the collection phaserelated to the collection phasetopic: fixturesanything involving fixtures directly or indirectlyanything involving fixtures directly or indirectlytype: backward compatibilitymight present some backward compatibility issues which should be carefully noted in the changelogmight present some backward compatibility issues which should be carefully noted in the changelog
These two modes currently use
session.perform_collect()directly to perform the collection.I don't see a reason for them to bypass the regular collection hook. If plugins do things with the hook on a regular run, they should do it for these two modes as well, just as they do with
--collect-only.This could possibly cause some breakage (though unlikely I think), so let's schedule this for pytest 10.0.