Preserve session and module teardown when fixture teardown fails#319
Merged
icemac merged 2 commits intopytest-dev:masterfrom Mar 3, 2026
Merged
Preserve session and module teardown when fixture teardown fails#319icemac merged 2 commits intopytest-dev:masterfrom
icemac merged 2 commits intopytest-dev:masterfrom
Conversation
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Contributor
|
Hi @emmanuel-ferdman! Thank you for the PR. I really like it. Could you please a an entry in the change log, that would make it perfect. |
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Contributor
Author
|
@icemac Added. thanks for the review! |
icemac
approved these changes
Mar 3, 2026
Contributor
|
@emmanuel-ferdman Sorry for letting you waiting so long. Everything is fine, I am going to merge it now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
When a fixture's teardown raised an exception and reruns were enabled, session and module scoped fixture teardowns were never executed. The cleanup logic was clearing the entire setup state stack instead of just removing the failed test item, which inadvertently removed the finalizers for higher-scoped fixtures. This PR fixes that by only removing the current test item from the stack.
Fixes #314.