Shuffle before other plugins' collection hooks - #746
Merged
Merged
Conversation
Fixes #701. Make pytest-randomly run first, even before other plugin’s collection hooks marked "tryfirst", by turning the hook into a hook wrapper. This ensures that pytest-django, and other plugins that group tests with a stable sort, apply their grouping on top of the shuffled order, making the final order reproducible from the seed. Now we require pytest 8 and pluggy 1.0, the first version to support hook wrappers.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #701.
Make pytest-randomly run first, even before other plugin’s collection hooks marked "tryfirst", by turning the hook into a hook wrapper.
This ensures that pytest-django, and other plugins that group tests with a stable sort, apply their grouping on top of the shuffled order, making the final order reproducible from the seed.
Now we require pytest 8 and pluggy 1.0, the first version to support hook wrappers.