Preserve assertion failures for keyword call expectations - #609
Open
oyeong011 wants to merge 1 commit into
Open
Conversation
Confidence: high Scope-risk: narrow Tested: Regression fails before fix and passes after; full suite results recorded externally Not-tested: Other operating systems and Python versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
stub.assert_has_calls(calls=[expected])after an unexpected call raisesIndexErrorinstead ofAssertionError. The upstreamunittest.mocksignature accepts thecallskeyword. Read expected calls from that keyword when no positional argument was supplied.The regression fails with IndexError before the change and passes afterward. The full suite passes: 92 tests on macOS/Python 3.12.13 with pytest 9.1.1. Ruff check/format and diff checks pass. Validation used installed wheel metadata for pytest assertion rewriting while PYTHONPATH pointed to the source checkout; no tests were excluded. Other platform/version combinations were not run.
AI assistance: OpenAI Codex assisted with implementation, tests, and this description. The reported checks were executed locally.