Skip to content

fix: rerun count with pytest-rerunfailures 16.7 #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicozdeb wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: rerun count with pytest-rerunfailures 16.7 #1086

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/pytest_html/basereport.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ def __init__(self, report_path, config, report_data, template, css):
)

self._reports = defaultdict(dict)
self._pending_reruns = set()
self._report = report_data
self._report.title = self._report_path.name
self._suite_start_time = time.time()
Expand Down Expand Up @@ -225,7 +226,14 @@ def pytest_runtest_logreport(self, report):
if key not in self._reports[report.nodeid]:
self._reports[report.nodeid][key] = list()
self._reports[report.nodeid][key].append(report)
self._pending_reruns.add(report.nodeid)
else:
if report.nodeid in self._pending_reruns:
self._pending_reruns.discard(report.nodeid)
# pytest-rerunfailures >= 16.7 reports a teardown after each
# rerun attempt: it does not mark the end of the test.
if report.when == "teardown":
return
self._reports[report.nodeid][key] = [report]

finished = report.when == "teardown" and report.outcome != "rerun"
Expand Down