-
Notifications
You must be signed in to change notification settings - Fork 172
Add support for pytest 9 and drop Python 3.9 support #1278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1278 +/- ##
==========================================
- Coverage 90.53% 90.46% -0.07%
==========================================
Files 2 2
Lines 412 409 -3
Branches 45 44 -1
==========================================
- Hits 373 370 -3
Misses 30 30
Partials 9 9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I assume the timeline protection is wanting me to add something for the changelog? I can't find any documentation on what it is looking for. |
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The message from chronographer is easily missable : No files matching re.compile('changelog.d/(?P<issue_number>[^\\./]+).(?P<fragment_type>security|removed|deprecated|added|changed|fixed|downstream)(.\d+)?(.[^\\./]+)*$') pattern added
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'm not in a position to merge this.
[pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Add changelog docs: Split up change fragment into separate ones.
|
Thanks @sanders41 ! I split up the existing news fragment, so that the removal of Python 3.9 support and the support for pytest 9 ends up in the Removed and Added sections of the changelog, respectively. Then I squashed the commits to clean up the history. Big thanks to @Pierre-Sassoulas as well for helping out! Honestly, I wouldn't mind you merging this PR. Release will follow in a couple of hours. I just want to check if it makes sense to include some of the other open PRs in the release. |
Pytest 9 dropped support for Python 3.9 so that is why I dropped it here.