fix: forward skip_flag to syncplay player invocation - #1872
Conversation
--skip generates a skip_flag (from ani-skip) that was already being passed to the mpv and flatpak-mpv player branches, but the syncplay branch never forwarded it, so intro-skipping silently did nothing when using -s/--syncplay together with --skip.
|
I'm very interested in this change. |
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011Q6f47MBpXqeffupBwpWjf
|
Bumped to 5.0.3 — thanks for catching that, I missed it in CONTRIBUTING. On the AI question, fair to ask. The bug and the fix are mine: I hit it running What I did put through an AI was the PR description, which is almost certainly what you picked up on. The version bump commit I just pushed was also AI-written, so that one carries a |
Summary
--skipcomputesskip_flagviaani-skipand forwards it to the*mpv*and*flatpak*mpv*player branches inplay_episode(), but the*yncpla*(syncplay) branch never included it, so combining-s/--syncplaywith--skipsilently did nothing.$skip_flagto the syncplay invocation's player-args passthrough (after--), matching the other mpv-based branches.Test plan
ani-cli -s --skip "<anime>"withani-skipinstalled and confirmed intro is skipped when launched via syncplay.ani-cli --skip "<anime>"(no syncplay) still skips intros as before.