-
-
Notifications
You must be signed in to change notification settings - Fork 10
Add img field to Pose table #546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fe51
wants to merge
12
commits into
main
Choose a base branch
from
pose-image
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #546 +/- ##
==========================================
+ Coverage 87.92% 88.14% +0.22%
==========================================
Files 50 50
Lines 1962 1990 +28
==========================================
+ Hits 1725 1754 +29
+ Misses 237 236 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
endpoint: cameras
endpoint: poses
ext: client/tests
ext: client
ext: scripts
ext: tests
module: models
module: schemas
topic: docs
Improvements or additions to documentation
type: improvement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #534
It introduces the following modifications
API Changes
Database Model (
models.py)image: Union[str, None]field toPosemodelSchemas (
poses.py)PoseImageschema for image updatesPoseRead:imageimage_urlCRUD (
crud_pose.py)PoseImageAPI Endpoints (
endpoints/poses.py)/api/v1/poses/{pose_id}image_url(presigned S3 URL)/api/v1/poses/{pose_id}/imageAuthorization
CAMERAADMINAGENTClient Changes
Routes (
client.py)POSES_IMAGEroute constantMethods (
client.py)update_pose_image(pose_id, media)methodTests
API Tests (
test_poses.py)test_get_pose_with_image()test_update_pose_image()imageandimage_urlClient Tests (
test_client.py)test_update_pose_image_camera()Fixtures (
conftest.py)POSE_TABLEwith image fieldsCamera Tests (
test_cameras.py)Documentation
DB Diagram (
dbdiagram.txt)image varcharfield toposestablePattern
Camera.last_imagefor consistency