Convert TOC y through CropBox origin, not crop height - #5111
Open
gyanu2507 wants to merge 1 commit into
Open
Conversation
set_toc treated the y as relative to a crop box whose origin is (0, 0). PDF destinations are in default user space, so a shifted CropBox offset the round-trip by CropBox.y0. Fixes pymupdf#4484
Contributor
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set_tocconverted a y value withcropbox.height - y. PDF destinations live in default user space (MediaBox), so when CropBox is shifted the round-trip fromget_tocwas off byCropBox.y0.The conversion now uses
cropbox.y1 - y, which is the same as before when CropBox matches MediaBox.Fixes #4484