Fix ModbusServerContext initialization with dict devices parameter#2944
Open
km-64 wants to merge 2 commits into
Open
Fix ModbusServerContext initialization with dict devices parameter#2944km-64 wants to merge 2 commits into
ModbusServerContext initialization with dict devices parameter#2944km-64 wants to merge 2 commits into
Conversation
- Append `entry.simdevice` not `entry` because it's the wrong type - Assign the `id` attribute of `entry.simdevice` not `entry`
Contributor
Author
|
Added type information mentioned in issue #2943 in |
Contributor
Author
|
Also more generally, I noticed that this file isn't formatted with Maybe at some point |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the solution described in issue #2943