-
Notifications
You must be signed in to change notification settings - Fork 88
Example Gallery #558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Example Gallery #558
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #558 +/- ##
=======================================
Coverage 96.50% 96.50%
=======================================
Files 31 31
Lines 4173 4173
=======================================
Hits 4027 4027
Misses 146 146 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
That is nice. Can only look on my phone now, will review tomorrow. |
| ancova_pymc.ipynb | ||
| ## ANCOVA | ||
|
|
||
| Analysis of covariance is a simple linear model, typically with one continuous predictor (the covariate) and a categorical variable (which may correspond to treatment or control group). In the context of this package, ANCOVA could be useful in pre-post treatment designs, either with or without random assignment. This is similar to the approach of difference in differences, but only applicable with a single pre and post treatment measure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drbenvincent feel free to push edits to these descriptions :)
juanitorduz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On model descriptions :)
drbenvincent
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this. Here's quick, first-pass review.
-
The left nabber feels rather empty now. It is possible to kill that? Or move the navigation (on the right) to the left and kill the right nav bar?
-
I notice the menu is now "Example Gallery" rather than "How-to". Don't know if I have strong feelings either way, but it's worth seeing if a consensus favourite emerges. If we switch I guess we should grep for any mentions of "how-to".
-
Can you give a thorough enough description in
CONTRIBUTING.mdandAGENTS.mdso that it's clear what to do when there's a new notebook.
I'll take a look at, and maybe edit, the descriptions in another round.
|
Thanks @drbenvincent ! Regarding your comments: The left nabber feels rather empty now. It is possible to kill that? Or move the navigation (on the right) to the left and kill the right nav bar? -> Added a table of contents on the side. I notice the menu is now "Example Gallery" rather than "How-to". Don't know if I have strong feelings either way, but it's worth seeing if a consensus favourite emerges. If we switch I guess we should grep for any mentions of "how-to". -> Reverted back to how-to for now. Can you give a thorough enough description in CONTRIBUTING.md and AGENTS.md so that it's clear what to do when there's a new notebook. done |
Show the examples in a gallery mode following the approach of pymc-labs/pymc-marketing#1611
📚 Documentation preview 📚: https://causalpy--558.org.readthedocs.build/en/558/