Remove symbolic axis from join/split#2144
Open
jessegrabowski wants to merge 4 commits into
Open
Conversation
Move axis from a symbolic Apply-node input to a __props__ property. Breaking change: Apply-node layout differs and c_code cache versions are bumped, so old pickled graphs will not load.
jessegrabowski
force-pushed
the
remove-symbolic-axis
branch
from
fa1a9e6 to
9927d10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1528
Removes the symbolic axis argument from join/split. Axis is now provided at Op construction time, so API goes from:
to:
Users who are using the public entrypoints (pt.concatenate, pt.stack, etc) should not see any change in behavior. Downstreams that use
Joindirectly will have to update, but this should be rare.