Remove setuptools from runtime dependency#2121
Open
ricardoV94 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops
setuptoolsas a runtime dependency. It only entered the runtime deps because aesara-devs/aesara#1050 (2022) and #277 (2023) reached forsetuptools._distutils.sysconfigandsetuptools.errors.CompileErrorto replace deprecateddistutils— stdlibsysconfighad identical equivalents the whole time, and_distutilsis a private namespace setuptools makes no stability promises about. The same concern was raised in #2026 but closed without action. Lazy imports in #1170 hid the cost; this PR removes it entirely.Swaps the four
setuptools._distutils.sysconfigcalls inlink/c/cmodule.pyto stdlibsysconfig, replacessetuptools.errors.CompileErrorwith a localExceptionsubclass, and dropssetuptoolsfrom[project.dependencies](kept in[build-system].requires).pytest tests/link/cpasses; verified thatpytensor.functionend-to-end still works withsetuptoolsblocked from import.Related issues: #2026, #481
Prior PRs: #277, #483, #812, #1170, aesara-devs/aesara#1050