Rewrite solve(matrix_inverse(X), b) → X @ b#2114
Merged
ricardoV94 merged 1 commit intoMay 5, 2026
Merged
Conversation
Member
You could have force-push to your old branch once you fixed it locally. |
ricardoV94
approved these changes
May 5, 2026
Member
|
Thanks @alessandrogentili001! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Opened a new PR and closed the previous one after getting troubles with git (my fault). By the way.
Update: Refactored Structural Testing
I have updated the PR to address the recent feedback regarding the test suite.
Key Changes:
WalkingGraphRewriterto the standardrewrite_graph(include=["stabilize"])pattern.assert_equal_computations. Both the rewritten graph and the expectedX @ bgraph are stabilized to ensure a common structural baseline (handling the internal lowering ofMatmulto BLAS ops likeDot).The implementation is verified to pass all tests and adheres to the latest repository linting standards.
Related Issue
Checklist
Type of change