Fix pandas roundtrip property test - #11575
Open
charles-turner-1 wants to merge 1 commit into
Open
Conversation
keewis
approved these changes
Sep 7, 2026
keewis
left a comment
keewis
left a comment
Collaborator
There was a problem hiding this comment.
looks good to me, thanks. I don't think people will ever use __temporary_name, but this is usually a really small cost usually (a string comparison).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If the series index name clashes with the temporary name (
"__temporary_name"), then just append (_fallback) to that name. Chance in a million, probably less, and might be worth altering the Hypothesis generation strategy to exclude this case instead.Checklist
I had AI (Claude Opus 4.8) pin down the cause of the failing property test and generate the MRE on the issue. Fix was written by hand.