fix: Don't drop orphaned dims on weighted reductions - #11562
Open
charles-turner-1 wants to merge 13 commits into
Open
fix: Don't drop orphaned dims on weighted reductions #11562charles-turner-1 wants to merge 13 commits into
charles-turner-1 wants to merge 13 commits into
Conversation
charles-turner-1
marked this pull request as draft
September 5, 2026 04:25
charles-turner-1
commented
Sep 5, 2026
… dims are missing in the test data
charles-turner-1
force-pushed
the
11560-weighted-orphaned-dims
branch
from
September 7, 2026 00:36
056c07d to
294d9e5
Compare
charles-turner-1
commented
Sep 7, 2026
…rles-turner-1/xarray into 11560-weighted-orphaned-dims
charles-turner-1
marked this pull request as ready for review
September 7, 2026 07:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
_restore_dimsmethod toDatasetWeightedwhich restored orphaned dims after a disjoint reduction.Checklist
whats-new.rstAI Disclosure
I asked Claude Opus 4.8 for help after getting stuck around 294d9e5.
All code human written.